-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support gVNIC #1296
feat: support gVNIC #1296
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
@bharathkkb this is a simple autogen-based change that enables gVNIC support on a per-nodepool basis. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @anoxape, looks like we also need a rebase.
We should also allow this per nodepool here
https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/cluster.tf#L300
@bharathkkb thanks, fixed and rebased |
@anoxape |
Co-authored-by: Bharath KKB <[email protected]>
No description provided.