Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update autogen template file extension #1285

Merged

Conversation

wyardley
Copy link
Contributor

@wyardley wyardley commented Jun 8, 2022

Update networks.tf to have the .tmpl extension like other files in the autogen hierarchy

Should help with automated expection in cases like:
aquasecurity/tfsec#1684

Update networks.tf to have the .tmpl extension like other files in the
autogen hierarchy

Should help with automated expection in cases like:
aquasecurity/tfsec#1684
@wyardley wyardley requested review from a team, Jberlinsky and bharathkkb as code owners June 8, 2022 15:35
@comment-bot-dev
Copy link

Thanks for the PR! 🚀
✅ Lint checks have passed.

@wyardley
Copy link
Contributor Author

wyardley commented Jun 8, 2022

Hi - great if someone can let me know if the test failures are related to the change or not. Locally, I don't think running the build / autogen stuff is changing any files, but I don't know if it's causing some other unexpected issue.

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @wyardley
Test failure looks unrelated #1280

@bharathkkb bharathkkb merged commit 37b5da8 into terraform-google-modules:master Jun 10, 2022
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
…es#1285)

Update networks.tf to have the .tmpl extension like other files in the
autogen hierarchy

Should help with automated expection in cases like:
aquasecurity/tfsec#1684
@wyardley wyardley deleted the wyardley/autogen branch September 13, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants