feat!: update TPG version constraints to 4.0 #1129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! 🚀 |
bharathkkb
force-pushed
the
1071-branch-provider-update
branch
2 times, most recently
from
596bcbb to
0dccbb7
Compare
* addresses warning about multiple provider blocks
* fetches main branch by default?
* temporary change until new version is released
* temporary change until new version of that dependency is released
* this should be removed once hashicorp/terraform-provider-google#10494 is addressed
bharathkkb
force-pushed
the
1071-branch-provider-update
branch
from
0dccbb7 to
2d8e5eb
Compare
bharathkkb
changed the title
bharathkkb
commented
Jan 21, 2022
| @@ -112,6 +112,7 @@ resource "google_compute_firewall" "master_webhooks" { | |||
| direction = "INGRESS" | |||
|
|
|||
| source_ranges = [local.cluster_endpoint_for_nodes] | |||
| source_tags = [] | |||
There was a problem hiding this comment.
Workaround for hashicorp/terraform-provider-google#10494. Long term fix maybe GoogleCloudPlatform/magic-modules#5526 but will need to validate.
bharathkkb
changed the title
|
@morgante PTAL since I rebased this and added a few commits |
morgante
suggested changes
Jan 21, 2022
| } | ||
| ``` | ||
|
|
||
| ### Acceptable values for node_metadata modified |
There was a problem hiding this comment.
Instead of requiring users to change this, I think we can provide a mapping at very low effort to ourselves. Could you add that?
There was a problem hiding this comment.
I updated the doc in e83bfc3 to make this a recommendation instead, encouraging users to switch to values that are supported by the provider.
morgante
approved these changes
Jan 21, 2022
Co-authored-by: Morgante Pell <[email protected]>
Closed
1 task
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
…s#1129) * feat: update TPG version constraints to allow 4.0 * Removes basic auth, renames namespace_identity * Regenerates modules and documentation * Updates tests to use latest Google provider * addresses warning about multiple provider blocks * Updates network module for Google provider 4.0 compatibility * Temporarily uses "main" for gcloud module (until next release is cut) * Comments out version constraint (temporary change) * fetches main branch by default? * Uses master branch for gcloud module (until release is cut) * Uses kubectl-wrapper where appropriate * Uses released version of gcloud module * Returns instance group URLs per node pool * Extends use of cluster_output_node_pools_ variables * Fixes documentation * Updates more modules * Updates READMEs to match variables * Uses master branch of bastion * temporary change until new version is released * Updates node pools versions description * Adds locals for node pool instance group URLs * Uses master branch of terraform-google-project-factory * temporary change until new version of that dependency is released * Updates project version ready for release * Updates pinned version of Google provider for example * Updates pinned version of Google provider in example * Addresses code review comments * Temporarily applies an empty source_tags setting. * this should be removed once hashicorp/terraform-provider-google#10494 is addressed * Fixes indentation * Uses newly-released version of project factory * Uses released version of bastion host * Removes use of SECURE mode (deprecated) * test empty source tag workaround * fix wi test * refactor IAM test for loose match * map old node meta value, add validations * update docs * Update autogen/main/variables.tf.tmpl Co-authored-by: Morgante Pell <[email protected]> * remove local Co-authored-by: cloud-foundation-bot <[email protected]> Co-authored-by: Jack Whelpton <[email protected]> Co-authored-by: Morgante Pell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based off of #1071 since I didnt have permission to push to the fork branch