Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy_service example prefixes endpoint with https:// #461

Closed
MajorBreakfast opened this issue Mar 20, 2020 · 2 comments
Closed

deploy_service example prefixes endpoint with https:// #461

MajorBreakfast opened this issue Mar 20, 2020 · 2 comments

Comments

@MajorBreakfast
Copy link
Contributor

host = "https://${module.gke.endpoint}"

Is adding https:// in front actually needed? For me, endpoint contains just a string containing an IP and it works without the https:// in front.

  • If it's needed, I'd like to create a PR that adds a comment that explains why it's required
  • If it's not needed, I'd like to create a PR that removes it and thus makes the example more minimalistic
@bharathkkb
Copy link
Member

@MajorBreakfast I dont think its needed; This example works file with out it.

@morgante
Copy link
Contributor

Yeah I think it's fine with or without it. Happy to accept a PR removing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants