Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the option to pass resource_labels to individual node pools #1507

Closed
eyalzek opened this issue Dec 22, 2022 · 0 comments · Fixed by #1508
Closed

Add the option to pass resource_labels to individual node pools #1507

eyalzek opened this issue Dec 22, 2022 · 0 comments · Fixed by #1508
Labels
enhancement New feature or request

Comments

@eyalzek
Copy link
Contributor

eyalzek commented Dec 22, 2022

TL;DR

Resource labels can be applied on the cluster level, or on the node pool level by passing node_config.resource_labels.

Terraform Resources

https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/container_cluster#resource_labels

Detailed design

Sometimes a user would want to configure resource labels on the node pool level (for cost allocation, etc).
This is currently possible to do with the Terraform Google provider, though not with the modules provided in this repository.

This can be done in the same way that `node_pools_labels` are passed down to node pool resources, but will of course require an additional variable to do so.

Additional information

No response
@eyalzek eyalzek added the enhancement New feature or request label Dec 22, 2022
eyalzek added a commit to eyalzek/terraform-google-kubernetes-engine that referenced this issue Dec 22, 2022
@eyalzek
feat: Add option to pass resource_labels to NP
00e6de7 
For configuring resource labels on a per node pool basis.

Fixes terraform-google-modules#1507
@eyalzek eyalzek mentioned this issue Dec 22, 2022
Merged
eyalzek added a commit to eyalzek/terraform-google-kubernetes-engine that referenced this issue Dec 28, 2022
@eyalzek
feat: Add option to pass resource_labels to NP
949fb4d 
For configuring resource labels on a per node pool basis.
Bump minimum provider version to 4.45.0.

Fixes terraform-google-modules#1507
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: Add option to pass resource_labels to NP eyalzek/terraform-google-kubernetes-engine
1 participant
@eyalzek