Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support gVNIC #1296

Merged
merged 2 commits into from
Jun 30, 2022
Merged

Conversation

anoxape
Copy link
Contributor

@anoxape anoxape commented Jun 20, 2022

No description provided.

@anoxape anoxape requested review from a team, Jberlinsky and bharathkkb as code owners June 20, 2022 07:25
@google-cla
Copy link

google-cla bot commented Jun 20, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@anoxape
Copy link
Contributor Author

anoxape commented Jun 26, 2022

@bharathkkb this is a simple autogen-based change that enables gVNIC support on a per-nodepool basis.
google & google-beta provider version requirements bumped to 4.14.0 which had it implemented

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @anoxape, looks like we also need a rebase.
We should also allow this per nodepool here
https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/cluster.tf#L300

@anoxape
Copy link
Contributor Author

anoxape commented Jun 29, 2022

@bharathkkb thanks, fixed and rebased
I also added enable_gvnic to force_node_pool_recreation_resources because it forces a replacement

@anoxape anoxape requested a review from bharathkkb June 29, 2022 07:40
@comment-bot-dev
Copy link

@anoxape
Thanks for the PR! 🚀
✅ Lint checks have passed.

@bharathkkb bharathkkb merged commit 5d6eac1 into terraform-google-modules:master Jun 30, 2022
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants