Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull useful example code into submodule #2

Closed
morgante opened this issue Feb 15, 2019 · 0 comments · Fixed by #21
Closed

Pull useful example code into submodule #2

morgante opened this issue Feb 15, 2019 · 0 comments · Fixed by #21
Assignees
@nick4fake
Labels
enhancement New feature or request triaged Scoped and ready for work

Comments

@morgante
Copy link
Contributor

Some of the code from the simple example, such as an artifact bucket, job templates, and firewall rules is generally usable and should be pulled into a submodule which can be directly consumed.
@morgante morgante added the enhancement New feature or request label Feb 15, 2019
@aaron-lane aaron-lane added the triaged Scoped and ready for work label Nov 16, 2019
@nick4fake nick4fake self-assigned this Nov 25, 2019
nick4fake added a commit to nick4fake/terraform-google-jenkins that referenced this issue Nov 29, 2019
@nick4fake
Fixes terraform-google-modules#2: Pull useful example code into submo…
d40994b 
…dule

terraform-google-modules#2

Added submodule for artifacts.
@nick4fake nick4fake mentioned this issue Nov 29, 2019
Merged
nick4fake added a commit to nick4fake/terraform-google-jenkins that referenced this issue Dec 3, 2019
@nick4fake
Fixes terraform-google-modules#2: Pull useful example code into submo…
581e1bc 
…dule

terraform-google-modules#2

Added submodule for artifacts.
nick4fake added a commit to nick4fake/terraform-google-jenkins that referenced this issue Dec 3, 2019
@nick4fake
Fixes terraform-google-modules#2: Pull useful example code into submo…
9c07e59 
…dule

terraform-google-modules#2

Added submodule for artifacts.
aaron-lane added a commit that referenced this issue Dec 3, 2019
@aaron-lane
Merge pull request #21 from nick4fake/fix/2
7e0fb78 
Fixes #2: Pull useful example code into submodule
aaron-lane added a commit that referenced this issue Dec 3, 2019
@aaron-lane
Add #2, 1.2.0 to CHANGELOG
d7717fb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nick4fake nick4fake

Labels
enhancement New feature or request triaged Scoped and ready for work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #2: Pull useful example code into submodule nick4fake/terraform-google-jenkins
3 participants
@nick4fake @morgante @aaron-lane