Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Terraform 0.12 #9

Merged
merged 5 commits into from
Aug 15, 2019
Merged

Update to Terraform 0.12 #9

merged 5 commits into from
Aug 15, 2019

Conversation

ludoo
Copy link
Contributor

@ludoo ludoo commented Aug 10, 2019

This PR updates the module to work with Terraform 0.12.

It also introduces a breaking change in outputs, where outputs for multiple buckets are switched from maps to list, so that hey preserve the same order as the names variable that is passed in, to avoid potential issues.

@ludoo ludoo requested a review from morgante August 10, 2019 18:00
Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor questions/issues.

Also FYI we don't need all the test boilerplate anymore (but you can keep it).

main.tf Outdated Show resolved Hide resolved
main.tf Show resolved Hide resolved
@morgante
Copy link
Contributor

LGTM, merge and release at will.

@ludoo ludoo merged commit c426e09 into master Aug 15, 2019
@aaron-lane aaron-lane deleted the ludo-0.12 branch September 6, 2019 18:43
aaron-lane added a commit that referenced this pull request Sep 6, 2019
This was referenced Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants