Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for max ports per vm #124

Merged
merged 2 commits into from
Jun 26, 2023
Merged

feat: add support for max ports per vm #124

merged 2 commits into from
Jun 26, 2023

Conversation

nikhilmakhijani
Copy link
Contributor

@nikhilmakhijani nikhilmakhijani commented Jun 23, 2023 •
edited
Loading

Issue #123 : Adding support for max ports per vm

@nikhilmakhijani nikhilmakhijani requested review from a team and imrannayer as code owners June 23, 2023 17:30
@nikhilmakhijani nikhilmakhijani changed the title fix(#123) : adding support for max ports per vm fix: adding support for max ports per vm Jun 23, 2023
@nikhilmakhijani
Copy link
Contributor Author

nikhilmakhijani commented Jun 23, 2023 •
edited
Loading

@apeabody / @g-awmalik could you please review

@nikhilmakhijani
Copy link
Contributor Author

/gcbrun

@nikhilmakhijani nikhilmakhijani mentioned this pull request Jun 23, 2023
Closed
@apeabody
Copy link
Contributor

/gcbrun

@imrannayer
Copy link
Collaborator

@nikhilmakhijani enable_dynamic_port_allocation needs to be true to set max_ports_per_vm. Can you plz ignore this value in terraform code if enable_dynamic_port_allocation is set to false.

  max_ports_per_vm  = var.enable_dynamic_port_allocation ? var.max_ports_per_vm : null

Also add it to variable max_ports_per_vm description "this will be ignored if enable_dynamic_port_allocation is set to false"

@nikhilmakhijani
Copy link
Contributor Author

@nikhilmakhijani enable_dynamic_port_allocation needs to be true to set max_ports_per_vm. Can you plz ignore this value in terraform code if enable_dynamic_port_allocation is set to false.

  max_ports_per_vm  = var.enable_dynamic_port_allocation ? var.max_ports_per_vm : null

Also add it to variable max_ports_per_vm description "this will be ignored if enable_dynamic_port_allocation is set to false"

Makes sense! I have added the changes suggested by you.

@imrannayer
Copy link
Collaborator

/gcbrun

@imrannayer imrannayer changed the title fix: adding support for max ports per vm feat: adding support for max ports per vm Jun 26, 2023
@imrannayer
Copy link
Collaborator

/gcbrun

@imrannayer imrannayer changed the title feat: adding support for max ports per vm feat: add support for max ports per vm Jun 26, 2023
@imrannayer imrannayer merged commit 8798307 into terraform-google-modules:master Jun 26, 2023
@release-please release-please bot mentioned this pull request Jun 26, 2023
Merged
@imrannayer imrannayer mentioned this pull request Jun 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imrannayer imrannayer imrannayer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nikhilmakhijani @apeabody @imrannayer