Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add local deployment instructions #1327

Merged
merged 21 commits into from
Dec 23, 2024
Merged

chore: add local deployment instructions #1327

merged 21 commits into from
Dec 23, 2024

Conversation

amandakarina
Copy link
Contributor

This PR adds instructions to deploy foundation locally, without Source Repository and without Cloud Build.

amandakarina and others added 12 commits August 14, 2024 14:57
@amandakarina
Adds instructions to deploy locally without Cloud Build.
ec5b86e
@amandakarina @caetano-colin
Apply suggestions from code review
c854402 
Co-authored-by: Caetano Colin <[email protected]>
@amandakarina
Moves project state bucket to main.tf file
9e34acd
@amandakarina
Fixes business_unit_2 commands
279c39b
@amandakarina
Merge branch 'fix/add-local-deployment-instructions' into fix/fix-bu2…
a5f4d2c 
…-copy-command
@caetano-colin @amandakarina
fix typo, add commit for git init and add some instructions
a60b76b
@amandakarina
Merge pull request #108 from amandakarina/fix/fix-bu2-copy-command
7c01f93 
Fixes business_unit_2 commands
@amandakarina
Fixes validator step at 0-bootstrap
2bfe7c2
@amandakarina
Moves projects bucket out cloud build sectin
9e038ef
@amandakarina
Undo markdown link modification
91b1f2a
@caetano-colin
add more instructions on sa.tf
b74055c
@amandakarina
Merge pull request #109 from caetano-colin/caetano-test-2
6066c62 
add more instructions on sa.tf
apeabody
apeabody approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amandakarina

A few trivial ? below

1-org/README.md Outdated Show resolved Hide resolved
1-org/README.md Outdated Show resolved Hide resolved
2-environments/README.md Outdated Show resolved Hide resolved
3-networks-dual-svpc/README.md Outdated Show resolved Hide resolved
3-networks-hub-and-spoke/README.md Outdated Show resolved Hide resolved
3-networks-hub-and-spoke/README.md Outdated Show resolved Hide resolved
4-projects/README.md Outdated Show resolved Hide resolved
4-projects/README.md Outdated Show resolved Hide resolved
@amandakarina
Copy link
Contributor Author

/gcbrun

@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Nov 10, 2024
@amandakarina amandakarina force-pushed the fix/add-local-deployment-instructions branch from 1958866 to 5adbebd Compare November 12, 2024 12:10
@daniel-cit daniel-cit removed the Stale label Nov 12, 2024
@amandakarina
Copy link
Contributor Author

/gcbrun

@amandakarina
Copy link
Contributor Author

/gcbrun

@apeabody
Copy link
Contributor

/gcbrun

@apeabody apeabody enabled auto-merge (squash) December 16, 2024 17:50
@apeabody
Copy link
Contributor

Doesn't appear the error is related to this change (project number vs ID):

Step #8 - "verify-org":     org_test.go:251: 
Step #8 - "verify-org":         	Error Trace:	/workspace/test/integration/org/org_test.go:251
Step #8 - "verify-org":         	            				/builder/home/go/pkg/mod/github.com/!google!cloud!platform/cloud-foundation-toolkit/infra/[email protected]/pkg/tft/terraform.go:638
Step #8 - "verify-org":         	            				/builder/home/go/pkg/mod/github.com/!google!cloud!platform/cloud-foundation-toolkit/infra/[email protected]/pkg/tft/terraform.go:670
Step #8 - "verify-org":         	            				/builder/home/go/pkg/mod/github.com/!google!cloud!platform/cloud-foundation-toolkit/infra/[email protected]/pkg/utils/stages.go:31
Step #8 - "verify-org":         	            				/builder/home/go/pkg/mod/github.com/!google!cloud!platform/cloud-foundation-toolkit/infra/[email protected]/pkg/tft/terraform.go:670
Step #8 - "verify-org":         	Error:      	Not equal: 
Step #8 - "verify-org":         	            	expected: "bigquery.googleapis.com/projects/200531796710/datasets/ds_c_prj_aggregated_logs_analytics"
Step #8 - "verify-org":         	            	actual  : "bigquery.googleapis.com/projects/kic-c-logging-4dje/datasets/ds_c_prj_aggregated_logs_analytics"
Step #8 - "verify-org":         	            	
Step #8 - "verify-org":         	            	Diff:
Step #8 - "verify-org":         	            	--- Expected
Step #8 - "verify-org":         	            	+++ Actual
Step #8 - "verify-org":         	            	@@ -1 +1 @@
Step #8 - "verify-org":         	            	-bigquery.googleapis.com/projects/200531796710/datasets/ds_c_prj_aggregated_logs_analytics
Step #8 - "verify-org":         	            	+bigquery.googleapis.com/projects/kic-c-logging-4dje/datasets/ds_c_prj_aggregated_logs_analytics
Step #8 - "verify-org":         	Test:       	TestOrg
Step #8 - "verify-org":         	Messages:   	log bucket BigQuery dataset ID should match

@amandakarina
Copy link
Contributor Author

amandakarina commented Dec 17, 2024 •
edited
Loading

Doesn't appear the error is related to this change (project number vs ID):

Step #8 - "verify-org":     org_test.go:251: 
Step #8 - "verify-org":         	Error Trace:	/workspace/test/integration/org/org_test.go:251
Step #8 - "verify-org":         	            				/builder/home/go/pkg/mod/github.com/!google!cloud!platform/cloud-foundation-toolkit/infra/[email protected]/pkg/tft/terraform.go:638
Step #8 - "verify-org":         	            				/builder/home/go/pkg/mod/github.com/!google!cloud!platform/cloud-foundation-toolkit/infra/[email protected]/pkg/tft/terraform.go:670
Step #8 - "verify-org":         	            				/builder/home/go/pkg/mod/github.com/!google!cloud!platform/cloud-foundation-toolkit/infra/[email protected]/pkg/utils/stages.go:31
Step #8 - "verify-org":         	            				/builder/home/go/pkg/mod/github.com/!google!cloud!platform/cloud-foundation-toolkit/infra/[email protected]/pkg/tft/terraform.go:670
Step #8 - "verify-org":         	Error:      	Not equal: 
Step #8 - "verify-org":         	            	expected: "bigquery.googleapis.com/projects/200531796710/datasets/ds_c_prj_aggregated_logs_analytics"
Step #8 - "verify-org":         	            	actual  : "bigquery.googleapis.com/projects/kic-c-logging-4dje/datasets/ds_c_prj_aggregated_logs_analytics"
Step #8 - "verify-org":         	            	
Step #8 - "verify-org":         	            	Diff:
Step #8 - "verify-org":         	            	--- Expected
Step #8 - "verify-org":         	            	+++ Actual
Step #8 - "verify-org":         	            	@@ -1 +1 @@
Step #8 - "verify-org":         	            	-bigquery.googleapis.com/projects/200531796710/datasets/ds_c_prj_aggregated_logs_analytics
Step #8 - "verify-org":         	            	+bigquery.googleapis.com/projects/kic-c-logging-4dje/datasets/ds_c_prj_aggregated_logs_analytics
Step #8 - "verify-org":         	Test:       	TestOrg
Step #8 - "verify-org":         	Messages:   	log bucket BigQuery dataset ID should match

I think PR #1354 will fix this.

@apeabody apeabody merged commit 1b08c16 into terraform-google-modules:master Dec 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeabody apeabody apeabody approved these changes

@rjerrems rjerrems Awaiting requested review from rjerrems rjerrems is a code owner

@gtsorbo gtsorbo Awaiting requested review from gtsorbo

@eeaton eeaton Awaiting requested review from eeaton eeaton is a code owner

@sleighton2022 sleighton2022 Awaiting requested review from sleighton2022

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amandakarina @apeabody @daniel-cit @caetano-colin