Add support for NFS and GCS mounts in Cloud Run v2 service #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add support for NFS and GCS mounts in Cloud Run v2 service ```release-note:enhancement cloudrunv2: added `nfs` field to `google_cloud_run_v2_service.template.volumes` cloudrunv2: added `gcs` field to `google_cloud_run_v2_service.template.volumes` cloudrunv2: adding tcpSocket field to `google_cloud_run_v2.template.containers.livenessProbe` ``` * fix: add required to relevant properties [upstream:1de3c302c346c96d1313a4f3ec7e3c815bd8de59] Signed-off-by: Modular Magician <[email protected]>
modular-magician
merged commit 0661977
into
terraform-google-modules:master
1 check passed
modular-magician
deleted the
downstream-pr-1de3c302c346c96d1313a4f3ec7e3c815bd8de59
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for NFS and GCS mounts in Cloud Run v2 service. The volume definitions are already in the REST API definition.
I also included the tcpSocket in the liveness_probe, as that was missing too.
PS: Updates were made using the magic-module-scaffolder which automates the updates of Magic Module resource definitions.
Derived from GoogleCloudPlatform/magic-modules#9728