Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

noskip related additions #314

Merged
merged 2 commits into from
Jul 9, 2020
Merged

Conversation

Kudbettin
Copy link
Member

Mentioned terraform-compliance is cloud agnostic
Removed Gherkin from code blocks, because it's not supported by github.

I can:

  • remove noskip examples and have more detailed noskip page as a child of using tags page
  • have the more detailed noskip page as noskip examples (removing the old page)
  • keep both.

Note: For some reason clicking a child of a child on the navbar collapses the navbar.

@coveralls
Copy link

coveralls commented Jul 7, 2020

Pull Request Test Coverage Report for Build 1099

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.3%) to 59.685%

Files with Coverage Reduction New Missed Lines %
terraform_compliance/common/defaults.py 6 84.21%
Totals Coverage Status
Change from base Build 1098: 0.3%
Covered Lines: 1288
Relevant Lines: 2158

💛 - Coveralls

@eerkunt
Copy link
Member

eerkunt commented Jul 8, 2020

This branch has merge conflict after merging #304. @Kudbettin can you fix it and then remove the Draft status whenever you want it to be reviewed ?

@Kudbettin Kudbettin marked this pull request as ready for review July 8, 2020 12:50
@Kudbettin
Copy link
Member Author

@eerkunt

Conflict resolved.

@eerkunt eerkunt merged commit 13d805a into terraform-compliance:master Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants