Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow spaces in the value of its_key_with_value #226

Merged

Conversation

ptiredknees
Copy link
Contributor

Not sure if this is abuse of the API, but I'd like to use When it's tags include <tag name>.
This change relaxes the custom type applied to value to ANY to allow for tag names that include spaces.

samtarplee and others added 4 commits March 3, 2020 14:02
…just returns a message saying "This method can only be used for aws_security_group resources for now. You tried to used it on aws_security_group_rule"
This currently doesn't work on aws_security_group_rule resources, it …
Copy link
Member

@eerkunt eerkunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good idea!

@eerkunt
Copy link
Member

eerkunt commented Mar 4, 2020

Thanks for the PR @ptiredknees. 🎉

@coveralls
Copy link

coveralls commented Mar 4, 2020

Pull Request Test Coverage Report for Build 828

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.4%) to 68.136%

Files with Coverage Reduction New Missed Lines %
terraform_compliance/common/defaults.py 6 80.65%
Totals Coverage Status
Change from base Build 823: 0.4%
Covered Lines: 1005
Relevant Lines: 1475

💛 - Coveralls

Copy link
Member

@eerkunt eerkunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change requested also requires slight change on the documentation too.

terraform_compliance/steps/steps.py Outdated Show resolved Hide resolved
@ptiredknees ptiredknees requested a review from eerkunt March 4, 2020 14:59
Copy link
Member

@eerkunt eerkunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, can you do it for the negative option for that step

@eerkunt
Copy link
Member

eerkunt commented Mar 4, 2020

Thanks a lot for the changes 🎉

@eerkunt eerkunt merged commit dd2bc78 into terraform-compliance:master Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants