-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow spaces in the value of its_key_with_value #226
Allow spaces in the value of its_key_with_value #226
Conversation
…just returns a message saying "This method can only be used for aws_security_group resources for now. You tried to used it on aws_security_group_rule"
This currently doesn't work on aws_security_group_rule resources, it …
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a good idea!
Thanks for the PR @ptiredknees. 🎉 |
Pull Request Test Coverage Report for Build 828
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change requested also requires slight change on the documentation too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, can you do it for the negative option for that step
Thanks a lot for the changes 🎉 |
Not sure if this is abuse of the API, but I'd like to use
When it's tags include <tag name>
.This change relaxes the custom type applied to value to
ANY
to allow for tag names that include spaces.