Fixed a misleading error message on IP/Port/CIDR Checks. (#127)

terraform-compliance · Jul 16, 2019 · d07119f · d07119f
1 parent b230185
commit d07119f
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,7 +1,10 @@
 # CHANGELOG
 
+### 1.0.24 (2019-07-16)
+* Fixed a failure message where it was misleading. (follow up on [#127](https://github.com/eerkunt/terraform-compliance/issues/127#issuecomment-511990432)) 
+
 ### 1.0.23 (2019-07-16)
-* Fixed a bug where a resource might have multiple values (with same key). (follow up on [#1261](https://github.com/eerkunt/terraform-compliance/issues/126))
+* Fixed a bug where a resource might have multiple values (with same key). (follow up on [#126](https://github.com/eerkunt/terraform-compliance/issues/126))
 * Improved `its value must not be null` step that is also checking if the value is set to `''`.
 
 ### 1.0.22 (2019-07-16)

diff --git a/terraform_compliance/common/helper.py b/terraform_compliance/common/helper.py
@@ -119,12 +119,13 @@ def validate_sg_rule(plan_data, params, condition):
 
         if not port_intersection and network_check:
             raise Failure('{}/{} ports are defined for {} network. '
-                          'Must be limited to {}/{}'.format('/'.join(plan_data['protocol']),
+                          'Must be limited to {}/{} and {}'.format('/'.join(plan_data['protocol']),
                                                             '{}-{}'.format(plan_data['from_port'],
                                                                            plan_data['to_port']),
                                                             plan_data['cidr_blocks'],
                                                             '/'.join(plan_data['protocol']),
-                                                            from_to_port))
+                                                            from_to_port,
+                                                            given_network))
 
     # Condition: must not have
     # Fail only if ;

diff --git a/terraform_compliance/main.py b/terraform_compliance/main.py
@@ -7,7 +7,7 @@
 from radish.main import main as call_radish
 
 __app_name__ = "terraform-compliance"
-__version__ = "1.0.23"
+__version__ = "1.0.24"
 
 print('{} v{} initiated\n'.format(__app_name__, __version__))