Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed aws_vpn_gateway_route_propagation for default route table #94

Closed
wants to merge 2 commits into from

Conversation

antonbabenko
Copy link
Member

Fix #85

@tyrken
Copy link

tyrken commented May 9, 2018

Just a +1 for this - just been using it & that helped for our situation. Would be nice to see it merged in with your other changes to master.

@sc250024
Copy link
Contributor

@antonbabenko Was there a reason this hadn't been merged yet? I agree with @tyrken , it would be nice to have this feature in the VPC module. Let me know if you need help with testing or something else. Thank you!

@antonbabenko
Copy link
Member Author

Yes, we should merge this and it is primarily correct, but should be rebased because aws_main_route_table_association and aws_default_route_table were removed since this PR was created.

Please finish this and test it properly.

@sc250024
Copy link
Contributor

@antonbabenko Without write access I cannot change the branch directly. Do you want me to spin up a new PR based off a fork?

@antonbabenko
Copy link
Member Author

Yes, please check out this PR and make a new fork. I can't grant write access to this repo.

@sc250024
Copy link
Contributor

This PR can be closed. Re-opened here: #133

@DrFaust92
Copy link
Contributor

@antonbabenko can we close this?

@antonbabenko antonbabenko deleted the fix-vpn-routes branch July 26, 2020 05:34
@github-actions
Copy link

github-actions bot commented Nov 1, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

private_propagating_vgws
4 participants