-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed aws_vpn_gateway_route_propagation for default route table #94
Conversation
Just a +1 for this - just been using it & that helped for our situation. Would be nice to see it merged in with your other changes to master. |
@antonbabenko Was there a reason this hadn't been merged yet? I agree with @tyrken , it would be nice to have this feature in the VPC module. Let me know if you need help with testing or something else. Thank you! |
Yes, we should merge this and it is primarily correct, but should be rebased because Please finish this and test it properly. |
@antonbabenko Without write access I cannot change the branch directly. Do you want me to spin up a new PR based off a fork? |
Yes, please check out this PR and make a new fork. I can't grant write access to this repo. |
This PR can be closed. Re-opened here: #133 |
@antonbabenko can we close this? |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Fix #85