fix: Do not replace NAT gateways when additional subnets are added #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuelmazzuola
changed the title
manuelmazzuola
force-pushed
the
fix-nat-gateway-replacement
branch
2 times, most recently
from
e8bfc7c to
4dff716
Compare
manuelmazzuola
force-pushed
the
fix-nat-gateway-replacement
branch
from
4dff716 to
2ded1dd
Compare
manuelmazzuola
changed the title
|
tf-controller plan output: No changes. Your infrastructure matches the configuration.
Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.
To apply this plan, please merge this pull request. |
bryantbiggs
reviewed
Apr 25, 2024
| @@ -1034,7 +1034,7 @@ resource "aws_route" "private_ipv6_egress" { | |||
|
|
|||
| locals { | |||
| nat_gateway_count = var.single_nat_gateway ? 1 : var.one_nat_gateway_per_az ? length(var.azs) : local.max_subnet_length | |||
| nat_gateway_ips = var.reuse_nat_ips ? var.external_nat_ip_ids : try(aws_eip.nat[*].id, []) | |||
| nat_gateway_ips = var.reuse_nat_ips ? var.external_nat_ip_ids : aws_eip.nat[*].id | |||
There was a problem hiding this comment.
why would this change make a difference?
There was a problem hiding this comment.
because the try statement can't be evaluated while planning, so the nat gateways are all replaced, despite the fact that they are not changed
bryantbiggs
changed the title
bryantbiggs
approved these changes
Apr 26, 2024
antonbabenko
pushed a commit
that referenced
this pull request
Apr 26, 2024
## [5.8.1](v5.8.0...v5.8.1) (2024-04-26) ### Bug Fixes * Do not replace NAT gateways when additional subnets are added ([#1055](#1055)) ([cf18c37](cf18c37))
|
This PR is included in version 5.8.1 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding new private subnets to an already deployed vpc module leads to the replacement of the nat gateways for all the subnets that already existing.
There is no reason to use the try function in that case.
Motivation and Context
Breaking Changes
none
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull requestBefore the change
After the change