Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constrain AWS provider for compatibility #32

Closed
brandonjbjelland opened this issue Nov 21, 2017 · 2 comments
Closed

Constrain AWS provider for compatibility #32

brandonjbjelland opened this issue Nov 21, 2017 · 2 comments

Comments

@brandonjbjelland
Copy link
Contributor

This module is now incompatible with older versions of the AWS provider (e.g. 0.1.4). I haven't tested whether it's possible or it works to constrain a provider within a module but I would think it does. If not, a note in the documentation would suffice.

AWS provider version 0.1.4 yields:

1 error(s) occurred:

* module.vpc.aws_nat_gateway.this: : invalid or unknown key: tags

I would guess this is common across a few old versions.

@antonbabenko
Copy link
Member

Good point. I was thinking about this myself for some time and think that adding to README is the best option for now.

ChairmanTubeAmp pushed a commit to Shapeways/terraform-aws-vpc that referenced this issue Nov 28, 2017
* 'master' of github.com:Shapeways/terraform-aws-vpc:
  Reverted bad merge, fixed terraform-aws-modules#33
  Set enable_dns_support=true by default
  Updated descriptions for DNS variables (closes terraform-aws-modules#14)
  Add version requirements in README.md (fixes terraform-aws-modules#32)
  Add version requirements in README.md
  make sure outputs are always valid (terraform-aws-modules#29)
  Add tags to the aws_vpc_dhcp_options resource (terraform-aws-modules#30)
  Add support for DHCP options set (terraform-aws-modules#20)
  terraform-aws-modules#22 add vpn gateway feature (terraform-aws-modules#24)
  Add cidr_block outputs to public and private subnets (terraform-aws-modules#19)
@github-actions
Copy link

github-actions bot commented Nov 6, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2022
waddamski pushed a commit to hmrc/terraform-aws-vpc that referenced this issue Jul 5, 2024
waddamski pushed a commit to hmrc/terraform-aws-vpc that referenced this issue Jul 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants