feat: Add support for transit gateway CIDR blocks #69
Conversation
| transit_gateway_cidr_blocks = var.transit_gateway_cidr_blocks | ||
|
|
||
| timeouts { | ||
| create = try(var.timeouts.create, null) |
There was a problem hiding this comment.
Just wondering if we should write vars like this or var.timeouts["create"]? What is more correct? I think we write it like var.timeouts["create"] in most places. Are there any drawbacks/benefits of any? I am lost :)
There was a problem hiding this comment.
I don't think there are any drawbacks of one way vs the other - this way was just less characters and fit with the other try() usage patterns
## [2.7.0](v2.6.0...v2.7.0) (2022-03-26) ### Features * Add support for transit gateway CIDR blocks ([#69](#69)) ([131ed50](131ed50))
|
This PR is included in version 2.7.0 🎉 |
|
Thank you for the PR @bryantbiggs ! Why has the major AWS Requirement version been bumped without bumping the major version of this module? Otherwise, it brakes |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
var.amazon_side_asndefault tonullwhich defaults to"64512"Motivation and Context
Breaking Changes
How Has This Been Tested?
examples/*projectsexamples/complete