feat: Add ability to create deny insecure transport policy #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostyaplis
force-pushed
the
feat-ssl-policy
branch
from
d7af646 to
25e15fe
Compare
kostyaplis
force-pushed
the
feat-ssl-policy
branch
from
04aaed0 to
ec4b2ef
Compare
kostyaplis
force-pushed
the
feat-ssl-policy
branch
from
ec4b2ef to
543b604
Compare
|
Thank you for this PR! v1.23.0 has been just released. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
attach_deny_insecure_transport_policyvariable introduced to attach a policy that denies non-SSL requests to the bucket.Motivation and Context
Quite common requirement for secure environments. Could be useful for module users.
implements #43
Breaking Changes
No breaking changes
How Has This Been Tested?
terraform plan/apply/destroyusingexamples/completeFound that enabling either
attach_elb_log_delivery_policyorattach_deny_insecure_transport_policyon existing bucket results to following error uponaws_s3_bucket_public_access_block.this[0]destruction:I understand it is a known issue and not related to introduced functionality. Terraform re-run applies changes successfully.