fix: Remove hardcoded aws partition in notifications sub-module #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-empson
changed the title
antonbabenko
requested changes
Jun 14, 2022
No worries, changes to examples reverted. |
antonbabenko
approved these changes
Jun 14, 2022
antonbabenko
pushed a commit
that referenced
this pull request
Jun 14, 2022
### [3.2.4](v3.2.3...v3.2.4) (2022-06-14) ### Bug Fixes * Remove hardcoded aws partition in notifications sub-module ([#165](#165)) ([c51db21](c51db21))
|
This PR is included in version 3.2.4 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the notifications sub-module, the AWS partition in local.bucket_arn, is hardcoded to "aws". When deploying this module in China regions, with create_sqs_policy set to true, it fails with the error:
Error: error putting S3 Bucket Notification Configuration: InvalidArgument: Unable to validate the following destination configurationsThis change replaces the hardcoded value with a data source to make it dynamic and allows for successful deployment in China.
Motivation and Context
To fix error messages when deploying to AWS China.
Fixes #159
Breaking Changes
No, this is a non-breaking change.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectsExisting notifications example deployed prior to my changes. Updated module with my changes and re-deployed, Terraform reported no changes required.
Added China-specific resources to the example, behind a conditional check. Deployed resources to cn-north-1 region with my changes and I no longer get any errors.
pre-commit run -aon my pull request