fix: Remove hardcoded aws partition in notifications sub-module (#165)

terraform-aws-modules · Jun 14, 2022 · c51db21 · c51db21
1 parent 8373e70
commit c51db21
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/modules/notification/README.md b/modules/notification/README.md
@@ -31,6 +31,7 @@ No modules.
 | [aws_arn.queue](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/arn) | data source |
 | [aws_iam_policy_document.sns](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/iam_policy_document) | data source |
 | [aws_iam_policy_document.sqs](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/iam_policy_document) | data source |
+| [aws_partition.this](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/partition) | data source |
 
 ## Inputs
 

diff --git a/modules/notification/main.tf b/modules/notification/main.tf
@@ -1,5 +1,7 @@
+data "aws_partition" "this" {}
+
 locals {
-  bucket_arn = coalesce(var.bucket_arn, "arn:aws:s3:::${var.bucket}")
+  bucket_arn = coalesce(var.bucket_arn, "arn:${data.aws_partition.this.partition}:s3:::${var.bucket}")
 
   # Convert from "arn:aws:sqs:eu-west-1:835367859851:bold-starling-0" into "https://sqs.eu-west-1.amazonaws.com/835367859851/bold-starling-0" if queue_id was not specified
   # queue_url used in aws_sqs_queue_policy is not the same as arn which is used in all other places