-
-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add managed secrets option #87
feat: Add managed secrets option #87
Conversation
9e6cbb8
to
63faee5
Compare
9da87ff
to
d67554d
Compare
Hi! Any chance to merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
173b493
into
terraform-aws-modules:master
And a new release version? 😅 |
hmmm, not sure why the autorelease isn't detecting it as a new release. @antonbabenko what do we do for this scenario? |
This PR is included in version 5.1.0 🎉 |
@bryantbiggs Looking at commits - https://github.com/terraform-aws-modules/terraform-aws-redshift/commits/master/ This PR was merged with the wrong commit title (commit 173b493). It should be "feat: ...", "fix: ...", so that Release GH Action does the work. Looking in the previous commits, there was also 9c90d53 which was ignored by the Release GH Action. |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Adds the
manage_master_password
option to the redshift clusterMotivation and Context
Reduces burden to manage secrets by having Redshift manage it directly.
Breaking Changes
No
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull request