Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add managed secrets option #87

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

nimish
Copy link
Contributor

@nimish nimish commented Nov 10, 2023

Description

Adds the manage_master_password option to the redshift cluster

Motivation and Context

Reduces burden to manage secrets by having Redshift manage it directly.

Breaking Changes

No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request
  • I have used this in a production upgrade of a redshift cluster

.gitignore Outdated Show resolved Hide resolved
examples/complete/.terraform.lock.hcl Outdated Show resolved Hide resolved
versions.tf Outdated Show resolved Hide resolved
versions.tf Outdated Show resolved Hide resolved
versions.tf Outdated Show resolved Hide resolved
@nimish nimish force-pushed the managed_secrets branch 2 times, most recently from 9e6cbb8 to 63faee5 Compare November 10, 2023 22:11
@nimish nimish changed the title add managed secrets option feat: add managed secrets option Nov 11, 2023
@nimish nimish changed the title feat: add managed secrets option feat: Add managed secrets option Nov 12, 2023
@delaskoff
Copy link

Hi! Any chance to merge?

Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@bryantbiggs bryantbiggs merged commit 173b493 into terraform-aws-modules:master Jan 11, 2024
7 of 8 checks passed
@yurii-automat
Copy link

And a new release version? 😅

@bryantbiggs
Copy link
Member

hmmm, not sure why the autorelease isn't detecting it as a new release. @antonbabenko what do we do for this scenario?

@antonbabenko
Copy link
Member

This PR is included in version 5.1.0 🎉

@antonbabenko
Copy link
Member

@bryantbiggs Looking at commits - https://github.com/terraform-aws-modules/terraform-aws-redshift/commits/master/

This PR was merged with the wrong commit title (commit 173b493). It should be "feat: ...", "fix: ...", so that Release GH Action does the work.

Looking in the previous commits, there was also 9c90d53 which was ignored by the Release GH Action.

Copy link

github-actions bot commented Mar 7, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants