Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Clarify the manage_master_user_password_rotation functionality #478

Conversation

magreenbaum
Copy link
Member

Description

Currently there is not a way to disable secretsmanager password rotation. There's a workaround which involves initially setting manage_master_user_password_rotation to true, applying, then updating the value to false and reapplying.
Adding documentation regarding the issue and workaround.

Motivation and Context

Updating documentation around a current limitation.

Breaking Changes

No.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@bryantbiggs bryantbiggs merged commit 685b01b into terraform-aws-modules:master Dec 20, 2024
12 checks passed
@magreenbaum magreenbaum deleted the docs/documentation_on_secrets_management_rotation branch December 20, 2024 14:31
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants