fix: Use existing CloudWatch log group to avoid duplication #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-pop
commented
Aug 13, 2020
| attach_cloudwatch_logs_policy = false | ||
| attach_policy_json = true | ||
| policy_json = element(concat(data.aws_iam_policy_document.lambda[*].json, [""]), 0) | ||
| use_existing_cloudwatch_log_group = aws_cloudwatch_log_group.lambda.name != "" ? true : false |
There was a problem hiding this comment.
We need to wait for the log group to be created first because the lambda module fetches this using a data source:
data "aws_cloudwatch_log_group" "lambda" {
count = var.create && var.create_function && ! var.create_layer && var.use_existing_cloudwatch_log_group ? 1 : 0
name = "/aws/lambda/${var.lambda_at_edge ? "us-east-1." : ""}${var.function_name}"
}
michaelm-88
approved these changes
Aug 13, 2020
|
Closing this one in favor of #99 where this problem has been solved. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Both this module and terraform-aws-lambda create a CloudWatch log group with the same name but different tags so they get duplicated hence throwing an error on creation.
Motivation and Context
Fixes #97
Breaking Changes
N/A
How Has This Been Tested?