Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Added Ruff (Python code formatter) #536

Merged
merged 2 commits into from
Jan 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 28 additions & 5 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ name: Tests

env:
PYTEST_VERSION: 7.4.4
RUFF_VERSION: 0.1.13
RUFF_PY_VERSION: 3.12

on:
push:
Expand All @@ -19,19 +21,40 @@ jobs:
python_version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
fail-fast: false
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4.1.1

- name: Set up Python ${{ matrix.python_version }}
uses: actions/setup-python@v3
uses: actions/setup-python@v5.0.0
with:
python-version: ${{ matrix.python_version }}

- name: Install poetry and tox
- name: Install poetry
shell: bash
run: |
pip install pytest==${PYTEST_VERSION}
pip install pytest==${{ env.PYTEST_VERSION }}

- name: Run tox
- name: Run pytest
shell: bash
run: |
python -m pytest -vvv tests/

format:
name: Ruff Format check
runs-on: ubuntu-latest
steps:
- uses: actions/[email protected]

- name: Set up Python
uses: actions/[email protected]
with:
python-version: ${{ env.RUFF_PY_VERSION }}

- name: Install ruff
shell: bash
run: |
pip install ruff==${{ env.RUFF_VERSION }}

- name: Run ruff format check
shell: bash
run: |
ruff format --check .
15 changes: 7 additions & 8 deletions examples/fixtures/python3.8-app2/index.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,17 @@
logger = logging.getLogger()
logger.setLevel(logging.INFO)

logging.getLogger('boto3').setLevel(logging.DEBUG)
logging.getLogger('botocore').setLevel(logging.DEBUG)
logging.getLogger("boto3").setLevel(logging.DEBUG)
logging.getLogger("botocore").setLevel(logging.DEBUG)

bucketName = os.environ["BUCKET_NAME"]
regionName = os.environ["REGION_NAME"]

bucketName = os.environ['BUCKET_NAME']
regionName = os.environ['REGION_NAME']

def lambda_handler(event, context):
client = boto3.client('s3', regionName)
client = boto3.client("s3", regionName)
response = client.put_object(
Bucket=bucketName,
Key=str(uuid4()),
Body=bytearray("Hello, World!", 'utf-8')
Bucket=bucketName, Key=str(uuid4()), Body=bytearray("Hello, World!", "utf-8")
)

logger.info(response)
Expand Down
Loading
Loading