Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed event source mapping filter criteria #272

Merged
merged 1 commit into from
Feb 23, 2022
Merged

fix: Fixed event source mapping filter criteria #272

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ resource "aws_lambda_event_source_mapping" "this" {

content {
filter {
pattern = lookup(filter_criteria, "pattern", null)
pattern = lookup(each.value["filter_criteria"], "pattern", null)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think instead we should change line 261 to

for_each = try(each.value.filter_criteria, [])

which should make 265 work as intended without changes (I think, haven't tried myself yet)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bryantbiggs This module is still full of lookup() expressions, so using try() is not so critical here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to follow what's done elsewhere in this module. I can change it if you want though.

}
}
}
Expand Down