-
-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for AWS Graviton2 powered functions #206
feat: Add support for AWS Graviton2 powered functions #206
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR! The draft looks great, there are couple of small things to do:
- Update minimum version requirements in
versions.tf
everywhere and rerunpre-commit run -a
to fix documentation (when the updated provider is released)? - Add support for the same feature in the Lambda Layer resource (
compatible_architectures
)? - Update example code to have at least one function deploying using
arm64
architecture.
If you can, please double-check whether we need to do anything in package.{tf,py}
related to the way how the filename hash is computed to make sure that the same function (same runtime, same source) can be deployed in different architectures? If there are any changes required, please make an issue about it and we take it in a separate PR.
95a675f
to
3038b7a
Compare
Hi @antonbabenko, I've updated this PR in accordance with your comments, please review when you get a chance. For the
|
Can you also update a complete example to show |
Signed-off-by: Andrei Krasnitski <[email protected]>
Signed-off-by: Andrei Krasnitski <[email protected]>
3038b7a
to
411c88a
Compare
Thanks @antonbabenko, |
Thank you, @Infra-Red ! v2.20.0 has been just released. |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Allow to configure
architectures
property in aws_lambda_function andcompatible_architectures
property in aws_lambda_layer_version configuration.Motivation and Context
Add missing parameter that is required to support AWS Lambda Functions Powered by AWS Graviton2 Processor.
https://aws.amazon.com/blogs/aws/aws-lambda-functions-powered-by-aws-graviton2-processor-run-your-functions-on-arm-and-get-up-to-34-better-price-performance/
Breaking Changes
None.
How Has This Been Tested?
examples/*
projectsCloses #207