feat: Support adding KMS replica keys #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryantbiggs
reviewed
Nov 21, 2022
bryantbiggs
reviewed
Nov 21, 2022
bryantbiggs
reviewed
Nov 21, 2022
bryantbiggs
reviewed
Nov 21, 2022
bryantbiggs
reviewed
Nov 21, 2022
bryantbiggs
reviewed
Nov 21, 2022
bryantbiggs
reviewed
Nov 21, 2022
There was a problem hiding this comment.
looks good - we'll need to update the outputs to include these new keys in the appropriate output values https://github.com/terraform-aws-modules/terraform-aws-kms/blob/master/outputs.tf#L5-L33
magreenbaum
commented
Nov 22, 2022
magreenbaum
commented
Nov 22, 2022
|
thumps up - cool issue. are there any plan to review this ? @bryantbiggs |
bryantbiggs
approved these changes
Jan 28, 2023
antonbabenko
pushed a commit
that referenced
this pull request
Jan 28, 2023
## [1.4.0](v1.3.1...v1.4.0) (2023-01-28) ### Features * Support adding KMS replica keys ([#9](#9)) ([9a7080b](9a7080b))
|
This PR is included in version 1.4.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support adding kms replica keys (standard and external).
Motivation and Context
https://docs.aws.amazon.com/kms/latest/developerguide/multi-region-keys-replicate.html
Breaking Changes
No.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request