Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Grants output marked as sensitive data #33

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

JoseAlvarezSonos
Copy link
Contributor

@JoseAlvarezSonos JoseAlvarezSonos commented Jun 11, 2024

Description

When using grants for KMS keys, Terraform reports the following:

│ Error: Output refers to sensitive values
│
│   on outputs.tf line 48:
│   48: output "grants" {

Therefore, adding the proper sensitive parameter to the grants output. The reason is that the grants expose a token that is considered to be sensitive.

Motivation and Context

This is related to this issue that was included in AWS provider version 5.51.0, where the grant_token output is marked as sensitive, and therefore as per Terraform error shows: To reduce the risk of accidentally exporting sensitive data that was intended to be only internal, Terraform requires that any root module output containing sensitive data be explicitly marked as sensitive, to confirm your intent..

Breaking Changes

No, in previous versions to 5.51.0 it will work fine, but in newer versions it won't.

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@JoseAlvarezSonos JoseAlvarezSonos changed the title Grants output marked as sensitive data fix: Grants output marked as sensitive data Jun 11, 2024
@antonbabenko antonbabenko changed the title fix: Grants output marked as sensitive data feat: Grants output marked as sensitive data Jun 12, 2024
@antonbabenko antonbabenko merged commit 965a52d into terraform-aws-modules:master Jun 12, 2024
8 checks passed
antonbabenko pushed a commit that referenced this pull request Jun 12, 2024
## [3.1.0](v3.0.0...v3.1.0) (2024-06-12)

### Features

* Grants output marked as sensitive data ([#33](#33)) ([965a52d](965a52d))
@antonbabenko
Copy link
Member

This PR is included in version 3.1.0 🎉

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants