Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add support for aliases and grants on aws_kms_external_key #3

Merged
merged 3 commits into from
Aug 15, 2022
Merged

fix: Add support for aliases and grants on aws_kms_external_key #3

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f3a2a23
Update main.tf
ORuessel Aug 12, 2022
659b79a
delete extra lines
Aug 14, 2022
8049df9
update fix last line
Aug 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ resource "aws_kms_alias" "this" {

name = var.aliases_use_name_prefix ? null : "alias/${each.value}"
name_prefix = var.aliases_use_name_prefix ? "alias/${each.value}-" : null
target_key_id = aws_kms_key.this[0].id
target_key_id = var.create_external ? aws_kms_external_key.this[0].id : aws_kms_key.this[0].key_id
}

################################################################################
Expand All @@ -264,7 +264,7 @@ resource "aws_kms_grant" "this" {
for_each = { for k, v in var.grants : k => v if var.create }

name = try(each.value.name, each.key)
key_id = aws_kms_key.this[0].key_id
key_id = var.create_external ? aws_kms_external_key.this[0].id : aws_kms_key.this[0].key_id
grantee_principal = each.value.grantee_principal
operations = each.value.operations

Expand Down