Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct boolean logic for enabling/disabling key owners policy statement #2

Merged

Conversation

bryantbiggs
Copy link
Member

Description

  • Correct boolean logic for enabling/disabling key owners policy statement

Motivation and Context

  • Currently, without specifying key_owners, users will get a malformed policy document. This looks like a copy+pasta error from the default policy statement block

Breaking Changes

  • No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@bryantbiggs bryantbiggs requested a review from antonbabenko July 13, 2022 21:34
@antonbabenko antonbabenko merged commit 944ea72 into terraform-aws-modules:master Jul 14, 2022
antonbabenko pushed a commit that referenced this pull request Jul 14, 2022
### [1.0.2](v1.0.1...v1.0.2) (2022-07-14)

### Bug Fixes

* Correct boolean logic for enabling/disabling key owners policy statement ([#2](#2)) ([944ea72](944ea72))
@antonbabenko
Copy link
Member

This PR is included in version 1.0.2 🎉

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants