Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add example for node draining #937

Closed
wants to merge 3 commits into from
Closed

docs: add example for node draining #937

wants to merge 3 commits into from

Conversation

karlderkaefer
Copy link

PR o'clock

Description

Im not sure if this fits into the repo. I did some research on the topic and want to share a possible solution. Im not sad if you reject this but still happy about any feedback.
There is an existing issue for that topic here #462
If you run a production cluster with this module an important feature is missing.
How to update eks worker kubernetes version or worker group variables without downtime?

One way to solve this is to create a lifecycle hook which will drain the node before shutting down instances.

Checklist

@max-rocket-internet
Copy link
Contributor

Yes, I think this PR is a bit much for this repo 😅 If we have this python code in here then we will also likely get PRs and issues for it, which I don't think we would be keen for.

@karlderkaefer you seem to have it nicely packaged together so why don't you create a standalone repo for this?

@karlderkaefer
Copy link
Author

Sry for late response. Thanks for response. I totally agree with your points, I close this PR. The reference repo can be found here although it's not 100% finished yet https://github.com/karlderkaefer/eks-node-drainer but at least it gives some ideas.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants