Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitting aws-auth and kubectl resources as they are not related #54

Merged
merged 4 commits into from
Jul 11, 2018
Merged

Splitting aws-auth and kubectl resources as they are not related #54

merged 4 commits into from
Jul 11, 2018

Conversation

max-rocket-internet
Copy link
Contributor

@max-rocket-internet max-rocket-internet commented Jul 9, 2018

Hi again,

Here I'm splitting the resources related to kubectl/kubeconfig and aws-auth as these are unrelated to each other.

For example, the aws-auth config map has nothing to do with configuring a kubectl session. So rather than have a single variable configure_kubectl_session for both, I've added a variable for each.

I've also renamed null_resource.configure_kubectl as it's not doing anything related to kubectl and also removed the trigger from this resource related to kubeconfig as it's also unrelated.

@max-rocket-internet max-rocket-internet changed the title Splitting aws-auth and kubectl related resources as they are not related Splitting aws-auth and kubectl resources as they are not related Jul 9, 2018
@brandonjbjelland
Copy link
Contributor

Hey again! Back for more? 🥇

I think we've managed to avoid a breaking change here though variable changes are often exactly that. Effectively, this splits out aws_auth from kubectl but also introduces a variable to control if we want to write the config file but not use it. I'll resolve the conflict and get this submitted. The value here is small but also given sane/non-disruptive defaults, the required interface doesn't actually grow, which is in part what I'm steering toward..

@brandonjbjelland brandonjbjelland self-requested a review July 11, 2018 08:12
@brandonjbjelland brandonjbjelland merged commit 3c4e28e into terraform-aws-modules:master Jul 11, 2018
@max-rocket-internet max-rocket-internet deleted the variable_fixes branch July 11, 2018 08:20
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants