Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to recreate ASG when LT or LC changes #465

Merged

Conversation

barryib
Copy link
Member

@barryib barryib commented Aug 7, 2019

PR o'clock

Description

This PR will allow user to recreate autoscalling groups when launch template or launch configuration changes.

Related to #462

Checklist

@max-rocket-internet
Copy link
Contributor

Interested to see what others think of this.

@max-rocket-internet
Copy link
Contributor

Can you please update the changelog?

Copy link
Contributor

@max-rocket-internet max-rocket-internet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please update the changelog.

@barryib
Copy link
Member Author

barryib commented Aug 20, 2019

@max-rocket-internet I updated the changelog.

@max-rocket-internet max-rocket-internet merged commit d8ed7d0 into terraform-aws-modules:master Aug 20, 2019
@barryib barryib deleted the tba/recreate-asg branch August 25, 2019 11:54
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants