-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Fix typo in nodeadm
examples
#2986
chore: Fix typo in nodeadm
examples
#2986
Conversation
* `apiVersion: node.eks.aws/v1alpha` -> `apiVersion: node.eks.aws/v1alpha1`
nodeadm
example typonodeadm
examples
The whitespace changes are due to the |
what does that mean? the files should be generated from simply running |
* `tofu apply` in `examples/user_data`
I can't find whats causing the line ending issues but it seems to be upstream "somewhere". we've had this raised recently as well #2974 so based on the upstream issue linked and one solution, hopefully that will resolve it. I also updated the file extension for the purely MIME multi-part user data to |
This PR is included in version 20.8.5 🎉 |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
apiVersion: node.eks.aws/v1alpha
->apiVersion: node.eks.aws/v1alpha1
Closes #2985
Motivation and Context
The
nodeadm
examples have a typo (v1alpha
is meant to bev1alpha1
)Breaking Changes
None
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull request