Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix typo in nodeadm examples #2986

Merged
merged 4 commits into from
Mar 25, 2024
Merged

chore: Fix typo in nodeadm examples #2986

merged 4 commits into from
Mar 25, 2024

Conversation

rblaine95
Copy link
Contributor

@rblaine95 rblaine95 commented Mar 25, 2024

Description

  • apiVersion: node.eks.aws/v1alpha -> apiVersion: node.eks.aws/v1alpha1

Closes #2985

Motivation and Context

The nodeadm examples have a typo (v1alpha is meant to be v1alpha1)

Breaking Changes

None

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

* `apiVersion: node.eks.aws/v1alpha` -> `apiVersion: node.eks.aws/v1alpha1`
@rblaine95 rblaine95 changed the title Fix nodeadm example typo chore: Fix nodeadm example typo Mar 25, 2024
@rblaine95 rblaine95 changed the title chore: Fix nodeadm example typo chore: Fix typo in nodeadm examples Mar 25, 2024
@rblaine95
Copy link
Contributor Author

The whitespace changes are due to the trim_trailing_whitespace = true in .editorconfig

@bryantbiggs
Copy link
Member

The whitespace changes are due to the trim_trailing_whitespace = true in .editorconfig

what does that mean? the files should be generated from simply running terraform apply in the user data example. I just want to minimize the amount of white space changes

* `tofu apply` in `examples/user_data`
@rblaine95
Copy link
Contributor Author

rblaine95 commented Mar 25, 2024

Interesting 🤔

I ran tofu apply in the examples/user_data directory to revert the whitespace changes.
Doing a git diff shows this:
image

Maybe the Terraform is generating Windows/DOS line ends (\r\n) instead of *nix (\n).

My Github Codespace automatically stripped these on save due to the end_of_line = lf config in the .editorconfig

@bryantbiggs
Copy link
Member

I can't find whats causing the line ending issues but it seems to be upstream "somewhere".

we've had this raised recently as well #2974

so based on the upstream issue linked and one solution, hopefully that will resolve it. I also updated the file extension for the purely MIME multi-part user data to .txt since having those as .sh doesn't make sense

@bryantbiggs bryantbiggs merged commit 07be37d into terraform-aws-modules:master Mar 25, 2024
17 checks passed
@rblaine95 rblaine95 deleted the chore/fix-nodeadm-typo branch March 26, 2024 08:00
@antonbabenko
Copy link
Member

This PR is included in version 20.8.5 🎉

Copy link

github-actions bot commented May 9, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in Amazon Linux 2023 nodeadm examples
3 participants