Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accurate description for workers_additional_policies #1712

Closed
wants to merge 1 commit into from

Conversation

schwichti
Copy link

Description

  • Description should mention it is a list of ARNs
  • It seems that workers_additional_policies are also effective for managed nodes (needs confirmation)
  • When you pass a custom role for your worker/managed node, it seems that the additional policies are overridden (needs confirmation)

Motivation and Context

I think the description is not precise.

Breaking Changes

None.

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects
    Haven't tested.

* Description should mention it is a list of ARNs
* It seems that `workers_additional_policies` are also effective for managed nodes (needs confirmation)
* When you pass a custom role for your worker/managed node, it seems that the additional policies are overridden (needs confirmation)
@bryantbiggs
Copy link
Member

closed with #1680

@bryantbiggs bryantbiggs closed this Jan 5, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants