fix: Fixed variable reference for snapshot_id

[mitom]

PR o'clock

Description

#1431 introduced a new option to set snapshot_id, however the variable it points at in https://github.com/terraform-aws-modules/terraform-aws-eks/pull/1431/files#diff-abc45b07ed4bab6d21313623302e9685703e3b4ad4a981fd57fe91c4c70095edR348 is a copy-paste from https://github.com/terraform-aws-modules/terraform-aws-eks/pull/1431/files#diff-20ed3fefbb3f6838784a6f0bbd11bbef818670a86cab676afefe1bed893f4d3dR528

Changed it to point at the right variable.

This is currently breaking our pipeline with the following error:

Error: Reference to undeclared resource on .terraform/modules/eks/workers.tf line 348, in resource "aws_launch_configuration" "workers":
  348:         block_device_mappings.value, 
A managed resource "block_device_mappings" "value" has not been declared in module.eks.

Please treat it as a hotfix.

Checklist

• README.md has been updated after any changes to variables and outputs. See https://github.com/terraform-aws-modules/terraform-aws-eks/#doc-generation

[daroga0002]

seems this impacting aws_launch_configuration we need some additional check and testing before merging this.

[daroga0002]

@mitom could you provide me EKS module config to replicate this problem (it will make testing faster)?

[mitom]

@daroga0002 Hey, yeah sure. You'll have to fill out the subnets and such to actually deploy it, but even without those being valid you can reproduce the error on just a plan:

module "eks" {
  source           = "terraform-aws-modules/eks/aws"
  version          = "17.21.0"
  cluster_name     = "test"
  cluster_version = "1.21"
  subnets          = ["subnet-12345"]
  write_kubeconfig = false
  vpc_id           = "vpc-123456"

  workers_group_defaults = {
    additional_ebs_volumes = [
      {
        block_device_name = "/dev/xvdb"
        volume_size = "30"
        volume_type = "gp3"
        encrypted = true
      }
    ]
  }
  worker_groups = [
      {
        instance_type = "m5.medium"
      }
    ]
}

To test the change works, you can add snapshot_id to the volume, it also shows up in the plan without deployment.

[daroga0002]

@mitom thank you for your contribution 🎉

@antonbabenko lets merge this

[antonbabenko]

@daroga0002 Please let me know when you have more PRs ready for merge and we can try to release a little bit bigger changes in a release.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.