Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add bootstrap_extra_args to managed node group submodule #1600

Closed

Conversation

artificial-aidan
Copy link

@artificial-aidan artificial-aidan commented Sep 24, 2021

PR o'clock

Description

Add the ability to set bootstrap args for managed node groups

#730

Checklist

@artificial-aidan artificial-aidan changed the title Add bootstrap_extra_args to managed node group submodule feat: Add bootstrap_extra_args to managed node group submodule Sep 24, 2021
@daroga0002
Copy link
Contributor

something like this is potentially addressed in #1577

Lets keep this open and I will review both PRs

@stale
Copy link

stale bot commented Oct 28, 2021

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
To track this PR (even if closed), please open a corresponding issue if one does not already exist.

@stale stale bot added the stale label Oct 28, 2021
@artificial-aidan
Copy link
Author

Not stale

@stale stale bot removed the stale label Oct 28, 2021
@stevehipwell
Copy link
Contributor

This design pattern was specifically rejected in previous PRs which is why #1577 is designed as it is. For your use case #1577 will give you everything you need via the environment variables.

@daroga0002
Copy link
Contributor

Similar feature was merged as part of #1577

@daroga0002 daroga0002 closed this Nov 2, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants