Add suspended_processes attributes to autoscaling_group #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@max-rocket-internet I fixed the empty list issue, terraform splits empty strings to [""] and the provider doesn't support it (hashicorp/terraform-provider-aws#1532). So I just used "compact" to remove the empty value. |
6 tasks
max-rocket-internet
suggested changes
Oct 9, 2018
CHANGELOG.md
Outdated
| @@ -23,6 +23,7 @@ project adheres to [Semantic Versioning](http://semver.org/). | |||
| - exposed `aws_eks_cluster` create and destroy timeouts (by @RGPosadas) | |||
| - exposed `placement_tenancy` for autoscaling group (by @monsterxx03) | |||
| - Allow port 443 from EKS service to nodes to run `metrics-server`. (by @max-rocket-internet) | |||
| - Added `suspended_processes` to `worker_groups` input (by @bkmeneguello) | |||
There was a problem hiding this comment.
This needs to go in the v1.8.0 section now as v1.7.0 is already released.
bkmeneguello
force-pushed
the
autoscaling_suspended_processes
branch
from
bc3ace2 to
19a9a7d
Compare
max-rocket-internet
approved these changes
Oct 9, 2018
nicgrayson
pushed a commit
to nicgrayson/terraform-aws-eks
that referenced
this pull request
Oct 29, 2018
* upstream/master: (25 commits) Update documentation for removed `configure_kubectl_session` (terraform-aws-modules#171) remove the checksum step Add target_group_arns to worker ASG (terraform-aws-modules#167) Removing 2 providers from the module (terraform-aws-modules#168) Removing aws_iam_service_linked_role from module (terraform-aws-modules#160) Adjust the order and correct/update the info (terraform-aws-modules#163) Ruby ver `2.4.2` -> `2.4.4` Move env vars into env section Remove `v` in `v0.11.8` Better version control Add suspended_processes attributes to autoscaling_group (terraform-aws-modules#159) Updating changelog for v1.7.0 (terraform-aws-modules#158) Revert "Add suspended_processes attributes to autoscaling_group (terraform-aws-modules#153)" (terraform-aws-modules#157) Add suspended_processes attributes to autoscaling_group (terraform-aws-modules#153) Add option to change worker placement_tenancy. (terraform-aws-modules#142) Allowing 443 to nodes from EKS service (terraform-aws-modules#148) Fixed issue with 'workers_group_defaults_defaults.iam_role_id' and added explicit depends_on for 'update_config_map_aws_auth' (terraform-aws-modules#147) Added timeout configs and variables to aws_eks_cluster resource (terraform-aws-modules#149) Fixing travis config (terraform-aws-modules#151) Fix for ERROR: 'aws_iam_instance_profile.workers' not found (terraform-aws-modules#141) ...
aykamko
pushed a commit
to crowd-ai/terraform-aws-eks
that referenced
this pull request
Dec 14, 2018
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR o'clock
Description
Closes #152
Checklist
terraform fmtandterraform validateboth work from the root andexamples/eks_test_fixturedirectories (look in CI for an example)terraform-docsperREADME.mdinstructions