feat: Add var.wait_for_cluster_timeout to allow configuring the wait for cluster timeout
#1420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SNA-rh
changed the title
barryib
reviewed
Jun 1, 2021
barryib
suggested changes
Jun 1, 2021
|
@barryib I updated the code. Let me know if it looks better now. I was not sure of the process, so I resolved the comment issues myself. I hope that's OK. |
barryib
approved these changes
Jun 1, 2021
barryib
changed the title
var.wait_for_cluster_timeout to allow configuring the wait for cluster timeout.
barryib
changed the title
var.wait_for_cluster_timeout to allow configuring the wait for cluster timeout.var.wait_for_cluster_timeout to allow configuring the wait for cluster timeout
barryib
changed the title
var.wait_for_cluster_timeout to allow configuring the wait for cluster timeoutvar.wait_for_cluster_timeout to allow configuring the wait for cluster timeout
|
Nice. Thanks @SNA-rh for you contribution. |
|
@barryib We're real excited to use this. Any idea when the next release gets cut that'd include it? |
|
Just released it in v17.1.0 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR o'clock
Description
During #1359 a default timeout of 300 seconds was set for this.
We create hundreds of clusters a day and have seen many clusters take longer than 300 seconds. Our team previously used the
wait_for_cluster_cmd(NOTE: This is no longer available in this module) variable to wait 600 seconds. Sometimes, even 5 minutes isn't even enough. This PR will make this configurable, so our clusters are more likely to come up by the time we need to apply aws auth.Resolves #1395
Checklist