feat: Drop asg_recreate_on_change feature to encourage the usage of Instance Refresh for EC2 Auto Scaling
#1360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 17, 2021
antonbabenko
approved these changes
May 17, 2021
|
@antonbabenko this was quick 💪 |
barryib
changed the title
asg_recreate_on_change feature to encourage the usage of instance_refreshasg_recreate_on_change feature to encourage the usage of Instance Refresh for EC2 Auto Scaling
barryib
added a commit
to barryib/terraform-aws-eks
that referenced
this pull request
May 20, 2021
… Instance Refresh for EC2 Auto Scaling (terraform-aws-modules#1360) BREAKING CHANGES: This module used `random_pet` resources to create a random name for the autoscaling group to force the autoscaling group to be re-created when the launch configuration or launch template was changed (if `recreate_asg_when_lc_changes = true` was set), causing the instances to be removed and re-provisioned each time there was an update. Those random_pet resources has been removed and in its place there is now a set of functionality provided by AWS and the Terraform AWS provider - Instance Refresh. We encourage those users to move on Instance Refresh for EC2 Auto Scaling.
ArchiFleKs
pushed a commit
to ArchiFleKs/terraform-aws-eks
that referenced
this pull request
Jun 1, 2021
… Instance Refresh for EC2 Auto Scaling (terraform-aws-modules#1360) BREAKING CHANGES: This module used `random_pet` resources to create a random name for the autoscaling group to force the autoscaling group to be re-created when the launch configuration or launch template was changed (if `recreate_asg_when_lc_changes = true` was set), causing the instances to be removed and re-provisioned each time there was an update. Those random_pet resources has been removed and in its place there is now a set of functionality provided by AWS and the Terraform AWS provider - Instance Refresh. We encourage those users to move on Instance Refresh for EC2 Auto Scaling.
PascalBourdier
added a commit
to PascalBourdier/terraform-aws-eks
that referenced
this pull request
Sep 22, 2021
`asg_recreate_on_change` feature was dropped here : terraform-aws-modules#1360
1 task
PascalBourdier
added a commit
to PascalBourdier/terraform-aws-eks
that referenced
this pull request
Sep 22, 2021
`asg_recreate_on_change` feature was dropped here : terraform-aws-modules#1360
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR o'clock
Description
This module used random_pet resources to create a random name for the autoscaling group to force the autoscaling group to be re-created when the launch configuration or launch template was changed (if
recreate_asg_when_lc_changes = truewas set), causing the instances to be removed and re-provisioned each time there was an update. Those random_pet resources has been removed and in its place there is now a set of functionality provided by AWS and the Terraform AWS provider - instance_refresh. We encourage those users to move oninstance_refresh.Go with #1224
Checklist