fix: Regression broken MNG with LT, introduced in 14.0

[philicious]

PR o'clock

Description

fixes #1211 , introduced in #1129

Checklist

• CI tests are passing
• README.md has been updated after any changes to variables and outputs. See https://github.com/terraform-aws-modules/terraform-aws-eks/#doc-generation

[philicious]

cc @ArchiFleKs

[philicious]

@barryib could have a look at this ? Cannot request reviews

[ArchiFleKs]

Do you want me to include this in my PR @philicious or wait until this is merge to rebase ?

[dusansusic]

I tested this but it still wants to recreate my existing node groups with launch templates. Have you tested this, @philicious ? I will have more time during the weekend.

[philicious]

@dusansusic its not a fix to prevent the recreation of MNGs. that might still happen because the addition of the capacity_type will cause them to be recreated. (but can be fixed up manually in TF-state if you feel lucky)

this PR fixes the situation where you are unable to either create or update MNGs at all , as the instance-type is set on the MNG by default, no matter if an LT is present, but you can only set it in either one of both

[philicious]

@ArchiFleKs uhm, I guess your PR will take longer to be finished and eventually merged. so I would prefer my PR/fix to be standalone and with a higher chance of getting merged earlier. but of course feel free to use the fix already

[thehar]

This regression is painful. Is there an ETA on shipping a patch?

[jcam]

+1 what thehar said. I guess I'll force my systems to use the v13 module for now, though i'm building new clusters this week and it'd be nice to not have to recreate everything a zillion times

[ArchiFleKs]

@philicious actually I forgot that it was already here https://github.com/terraform-aws-modules/terraform-aws-eks/pull/1138/files#diff-7a3fc6c7df17fda0c341e61255461bf1f149256a9ddf14d4a18ab6f020d08136R17

[barryib]

@philicious is this PR still needed ? If yes, can you please update your branch ?

[philicious]

@barryib nope, fixed by #1138

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.