docs: Clarify about the cluster_endpoint_private_access_cidrs usage

[jerryaldrichiii]

PR o'clock

Description

This clarifies that cluster_create_endpoint_private_access_sg_rule needs to be set to true to use cluster_endpoint_private_access_cidrs

See:

terraform-aws-eks/cluster.tf

Line 52 in 65777d0

count = var.create_eks && var.cluster_create_endpoint_private_access_sg_rule && var.cluster_endpoint_private_access ? 1 : 0

Checklist

• CI tests are passing
• README.md has been updated after any changes to variables and outputs. See https://github.com/terraform-aws-modules/terraform-aws-eks/#doc-generation

[jerryaldrichiii]

I'm not sure why Lint / Docs is failing...but I feel like it's not related to this change.

Let me know if I need to fix anything.

[barryib]

The docs in the readme is autogenerated. So you just need to modify the variable description and run pre-commit run -a terraform_docs. See https://github.com/terraform-aws-modules/terraform-aws-eks#doc-generation

[jerryaldrichiii]

All better. Bit too much to jump through as an external contributor so I just added it manually.

Some day I may make a pre-commit Docker container. Thanks for responding so quickly.

[barryib]

@jerryaldrichiii can you please update your branch and resolve conflict on readme ?

[barryib]

closing in favor of #1400

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.