fix: Update autoscaling group tags -> tag to support v4 of AWS provider
#1866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -378,6 +406,15 @@ resource "aws_autoscaling_group" "this" { | |||
| } | |||
| } | |||
|
|
|||
| dynamic "tag" { | |||
| for_each = { for tag in local.asg_tags : "${tag.key}-${tag.value}" => tag } | |||
There was a problem hiding this comment.
Same comment as in another PR - terraform-aws-modules/terraform-aws-autoscaling#179
|
It is so much cleaner now! 🚀 |
antonbabenko
pushed a commit
that referenced
this pull request
Feb 15, 2022
### [18.6.1](v18.6.0...v18.6.1) (2022-02-15) ### Bug Fixes * Update autoscaling group `tags` -> `tag` to support v4 of AWS provider ([#1866](#1866)) ([74ad4b0](74ad4b0))
|
This PR is included in version 18.6.1 🎉 |
baibailiha
added a commit
to baibailiha/terraform-aws-eks
that referenced
this pull request
Sep 13, 2022
### [18.6.1](terraform-aws-modules/terraform-aws-eks@v18.6.0...v18.6.1) (2022-02-15) ### Bug Fixes * Update autoscaling group `tags` -> `tag` to support v4 of AWS provider ([#1866](terraform-aws-modules/terraform-aws-eks#1866)) ([1892b1e](terraform-aws-modules/terraform-aws-eks@1892b1e))
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
tags->tagto support v4 of AWS provider. This is now a dynamictagblock and the current functionality has been preserved through a map comprehension statement. The variablevar.propagate_tagshas been removed as part of this change and users should pass any tags through the normalvar.tagsvariable nowMotivation and Context
tagson autoscaling groupBreaking Changes
var.propagate_tagsis removed andvar.tagsis used in its place so I am (controversially) electing to not mark this as a breaking change (does not affect a significant population of users and there is a clear path to mitigate without state changes or downtime)How Has This Been Tested?
examples/*projects