Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment of EKS managed node group gives deprecation warning from self-managed-node-group #1874

Closed
ekakela opened this issue Feb 14, 2022 · 2 comments · Fixed by #1866
Closed

Comments

@ekakela
Copy link

ekakela commented Feb 14, 2022

Description

I am using the latest version of module with ```
eks_managed_node_groups = {
primary = {
min_size = 2
max_size = 4
desired_size = 2

  instance_types = ["t3.large"]
  capacity_type  = "ON_DEMAND"
  labels = {
    customer_name = var.customer_name
  }
}

}
}


But terraform apply complains always on the apply that 

│ Warning: Argument is deprecated

│ with module.EKS-Cluster.module.eks.module.self_managed_node_group.aws_autoscaling_group.this,
│ on .terraform/modules/EKS-Cluster.eks/modules/self-managed-node-group/main.tf line 392, in resource "aws_autoscaling_group" "this":
│ 392: tags = concat(
│ 393: [
│ 394: {
│ 395: key = "Name"
│ 396: value = var.name
│ 397: propagate_at_launch = true
│ 398: },
│ 399: {
│ 400: key = "kubernetes.io/cluster/${var.cluster_name}"
│ 401: value = "owned"
│ 402: propagate_at_launch = true
│ 403: },
│ 404: {
│ 405: key = "k8s.io/cluster/${var.cluster_name}"
│ 406: value = "owned"
│ 407: propagate_at_launch = true
│ 408: },
│ 409: ],
│ 410: var.propagate_tags,
│ 411: [for k, v in var.tags :
│ 412: {
│ 413: key = k
│ 414: value = v
│ 415: propagate_at_launch = true
│ 416: }
│ 417: ]
│ 418: )

│ Use tag instead



## Versions
 - Terraform: Terraform v1.1.5
 - Provider(s):
+ provider registry.terraform.io/hashicorp/aws v4.0.0
+ provider registry.terraform.io/hashicorp/cloudinit v2.2.0
+ provider registry.terraform.io/hashicorp/kubernetes v2.8.0
+ provider registry.terraform.io/hashicorp/tls v3.1.0

 - Module: Latest

## Reproduction
Deploy EKS cluster with eks_managed_node_group


## Expected behavior
Should not give warnings on self_managed_node group when using eks_managed_node_Group

@antonbabenko
Copy link
Member

This issue has been resolved in version 18.6.1 🎉

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants