feat: Added throughput support for root and EBS disks

[junaid-ali]

PR o'clock

Description

Fixes #1444
When gp3 disk type is used, throughput should be configurable for an ASG launch configuration. This PR adds that support.

Example usage:

module "eks" {
  ...

  worker_groups_launch_template = [
    {
      name                   = "worker-group-gp3"
      instance_type          = "t3.small"
      asg_desired_capacity   = 1
      public_ip              = true
      root_volume_size       = 150
      root_volume_type       = "gp3"
      root_volume_throughput = 300 # setting throughput to 300 MiB/s
    },
  ]
}

Checklist

- [ ] README.md has been updated after any changes to variables and outputs. See https://github.com/terraform-aws-modules/terraform-aws-eks/#doc-generation

[junaid-ali]

@daroga0002, @barryib any chance if you can have a look at this?

[junaid-ali]

@barryib @max-rocket-internet @daroga0002, could you please have a look at this XS PR?

[junaid-ali]

Updating the PR subject to fix since the user-provided root_volume_throughput will not be reflected

[daroga0002]

@antonbabenko 👍 +1:

[antonbabenko]

@junaid-ali Please update the PR and add throughput for EBS volumes and update code in examples/launch_templates to show this feature in action, too.

[junaid-ali]

thanks @antonbabenko , @daroga0002 for the review, I'll add the example

[junaid-ali]

@antonbabenko added the example usage to examples/launch_templates, and PR description as well. Attached is the plan output:

Could you please have a look at it again?

[antonbabenko]

I don't see changes for throughput inside of ebs_block_device block here and not in examples. Have you pushed all the changes?

[junaid-ali]

Version updated in the README

[antonbabenko]

The code looks good, but I want to verify it a bit more during this week.

[antonbabenko]

Thanks @junaid-ali !

v17.7.0 has been just released.

PS: I am unsure whether we need to implement the same changes in modules/node_groups. WDYT @daroga0002 ?

[daroga0002]

This can be added to launch template scenario:

terraform-aws-eks/modules/node_groups/launch_template.tf

Lines 35 to 41 in c2bd137

	ebs {
	volume_size = lookup(each.value, "disk_size", null)
	volume_type = lookup(each.value, "disk_type", null)
	encrypted = lookup(each.value, "disk_encrypted", null)
	kms_key_id = lookup(each.value, "disk_kms_key_id", null)
	delete_on_termination = true
	}

Fully AWS managed groups doesn't have such option:
https://docs.aws.amazon.com/eks/latest/APIReference/API_Nodegroup.html

[daroga0002]

seems issue for this enhancement was created:
#1567

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.