Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throughput support for gp3 disk type in launch configuration #1444

Closed
junaid-ali opened this issue Jun 15, 2021 · 1 comment · Fixed by #1445
Closed

Throughput support for gp3 disk type in launch configuration #1444

junaid-ali opened this issue Jun 15, 2021 · 1 comment · Fixed by #1445

Comments

@junaid-ali
Copy link
Contributor

Description

Throughput support is added to aws_launch_configuration resource in provider 3.44.0

⚠️ Note

Before you submit an issue, please perform the following first:

  1. Remove the local .terraform directory (! ONLY if state is stored remotely, which hopefully you are following that best practice!): rm -rf .terraform/
  2. Re-initialize the project root to pull down modules: terraform init
  3. Re-attempt your terraform plan or apply and check if the issue still persists

When we provide gp3 as root_volume_type in workers_groups, and also update the throughput for the gp3 disk, the changes doesn't get reflected. A fix/improvement would be to add root_volume_throughput config here similar to the other configs

Versions

  • Terraform: 0.14.11
  • Provider(s): 3.44.0
  • Module: latest

Reproduction

Steps to reproduce the behavior:

Code Snippet to Reproduce

module "eks" {
  source          = "terraform-aws-modules/eks/aws"
  cluster_name    = local.cluster_name
  cluster_version = "1.18"
  subnets         = [<subnets>]

  tags = local.common_tags

  vpc_id = <vpc-id>

  worker_groups = [
    {
      name                          = "worker-group-1"
      instance_type                 = "t3.medium"
      additional_userdata           = local.additional_userdata
      additional_security_group_ids = [<sec groups>]
      root_volume_size              = 120
      root_volume_type              = "gp2"
      root_volume_throughput        = 350
      asg_min_size                  = 2
      asg_max_size                  = 5
      tags                          = flatten(local.worker_tags)
    },
  ]
}

Expected behavior

Throughput configuration of 350 MiB/s should have reflected in the provisioned volume

Actual behavior

Throughput value is the default 125 MiB/s

Terminal Output Screenshot(s)

Additional context

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant