-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: bug with data source in managed groups submodule (#1633)
- Loading branch information
1 parent
f198efd
commit 54a5f1e
Showing
2 changed files
with
4 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,6 @@ | ||
data "aws_eks_cluster" "default" { | ||
count = var.create_eks ? 1 : 0 | ||
|
||
name = var.cluster_name | ||
} | ||
|
||
|
54a5f1e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change makes creating new cluster impossible because when var.create_eks=true (default), then count=1 and then data tries to get info about "EXISTING" cluster and it fails with the error below because it does not exist yet.
Am I overlooking something or this commit is simply wrong?
54a5f1e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same problem for me
54a5f1e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same issue
54a5f1e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we are aware of this issue and working on solution, but in general you can pin exact version of module into your code (what is best practice in terraform)