Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Create backup policy conditionally #5

Merged
merged 3 commits into from
Dec 9, 2022

Conversation

jeenadeepak
Copy link
Contributor

Description

Introduce create_backup_policy flag, on bases of which we will decide that either to create aws_efs_backup_policy resource or not.

Motivation and Context

Terraform apply command failed partially when aws backup is not available for any specific region, I have disabled enable_backup_policy but still it is throwing error.

@jeenadeepak jeenadeepak changed the title Backup policy error fix: Backup policy error Dec 8, 2022
Copy link
Contributor Author

@jeenadeepak jeenadeepak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix: Backup policy error

@bryantbiggs
Copy link
Member

you will need to run pre-commit run terraform-docs -a to update docs for this change

@jeenadeepak
Copy link
Contributor Author

you will need to run pre-commit run terraform-docs -a to update docs for this change

Done

@antonbabenko antonbabenko changed the title fix: Backup policy error fix: Create backup policy conditionally Dec 9, 2022
@antonbabenko antonbabenko merged commit 6154c0c into terraform-aws-modules:master Dec 9, 2022
antonbabenko pushed a commit that referenced this pull request Dec 9, 2022
### [1.0.2](v1.0.1...v1.0.2) (2022-12-09)

### Bug Fixes

* Create backup policy conditionally ([#5](#5)) ([6154c0c](6154c0c))
@antonbabenko
Copy link
Member

This PR is included in version 1.0.2 🎉

@bryantbiggs bryantbiggs mentioned this pull request Dec 16, 2022
@github-actions
Copy link

github-actions bot commented Jan 9, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants