Move volume_tags into dynamic blocks's tags parameter #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This effectively removes the churn-ing that is happening when an ebs_volume is attached separately from the module Takes advantage of the new feature in the aws provider available as of 3.24.0. hashicorp/terraform-provider-aws#15474
dekimsey
changed the title
|
Food for thought: my implementation does not allow for per-volume tag overrides. I think maybe it should, it would alter the TF to look something like: |
|
This PR has been automatically marked as stale because it has been open 30 days |
|
This PR was automatically closed because of stale in 10 days |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This effectively removes the churning that is happening when an
ebs_volume is attached separately from the module
Takes advantage of the new feature in the aws provider available as of 3.24.0.
hashicorp/terraform-provider-aws#15474
Motivation and Context
When using this module and creating aws_ebs_volumes/aws_ebs_volume_attachments outside of the module causes constant apply churn because the tags conflict.
Breaking Changes
Tags on the ebs_block_volumes may change
Requires 3.24.0 of aws provider, since this is a major version requirement change in the module
How Has This Been Tested?
I took existing instances with externally defined ebs_volumes and upgraded to this module. I also created resources anew.
Note: I'm still doing a bit more testing to validate, I did notice some initial churn (had to apply twice). But even this is a major behavior improvement.